Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter warnings #105

Merged
merged 13 commits into from
Mar 10, 2025
Merged

Fix linter warnings #105

merged 13 commits into from
Mar 10, 2025

Conversation

sengels-tum
Copy link
Collaborator

@sengels-tum sengels-tum commented Feb 21, 2025 •
edited
Loading

Description

This PR fixes all linter warnings due to an updated version of cpp-linter.

P.S.: Moreover, it changes CTEST_PARALLEL_LEVEL to 4, because the Gurobi licensing issues seem to have been caused by multiple CI jobs running in parallel and not directly by google tests running in parallel.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.27586% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.3%. Comparing base (7af816e) to head (fc399d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/solver/mip-based/GenPOMovingBlockMIPSolver.cpp 75.0% 2 Missing ⚠️
...olver/mip-based/GenPOMovingBlockMIPSolver_Lazy.cpp 90.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #105     +/-   ##
=======================================
- Coverage   97.3%   97.3%   -0.1%     
=======================================
  Files         44      44             
  Lines      13108   13060     -48     
  Branches    1571    1559     -12     
=======================================
- Hits       12758   12708     -50     
- Misses       350     352      +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sengels-tum sengels-tum changed the title Run cpp-linter on all files Fix linter warnings Feb 21, 2025
@sengels-tum
Revert "check all file´s"
fc399d1 
This reverts commit 70286de.
@sengels-tum sengels-tum marked this pull request as ready for review February 21, 2025 15:48
@sengels-tum sengels-tum requested a review from pehamTom February 21, 2025 16:36
pehamTom
pehamTom approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@pehamTom pehamTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sengels-tum sengels-tum merged commit d4d5757 into main Mar 10, 2025
12 checks passed
@sengels-tum sengels-tum deleted the full-linter-2025 branch March 10, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehamTom pehamTom pehamTom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sengels-tum @pehamTom